Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare anvil before deploy #2

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

prepare anvil before deploy #2

wants to merge 5 commits into from

Conversation

holic
Copy link

@holic holic commented Sep 24, 2024

pulled out of coinbase/smart-wallet#89

@holic holic mentioned this pull request Sep 24, 2024
Open
wilsoncusack
wilsoncusack reviewed Sep 24, 2024
View reviewed changes
Copy link
Owner

@wilsoncusack wilsoncusack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you write a test please?

@holic
Copy link
Author

holic commented Sep 24, 2024

Thank you! Could you write a test please?

What kind of test are you expecting? This is already covered by the previous setUp function, now replaced by this behavior as it happens on every deploy call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsoncusack wilsoncusack wilsoncusack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holic @wilsoncusack