Use caching response wrapper in case views render pre-emptively #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some View implementations will (not unreasonably) call response.getWriter() and write content directly. This is an error (in the spec I think) and Tomcat, for example, will barf. You can dodge the bullet by using an existing mechanism in Spring.
checketts
approved these changes
Jul 25, 2023
dsyer
pushed a commit
to dsyer/htmx-spring-boot-thymeleaf
that referenced
this pull request
Jul 30, 2023
Use caching response wrapper in case views render pre-emptively
dsyer
pushed a commit
to dsyer/htmx-spring-boot-thymeleaf
that referenced
this pull request
Jul 30, 2023
Use caching response wrapper in case views render pre-emptively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
Viewimplementations will (not unreasonably) callresponse.getWriter()and write content directly. This is an error (in the spec I think) and Tomcat, for example, will barf. You can dodge the bullet by using an existing mechanism in Spring.