Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PAT to get higher github rate-limit #449

Closed
wants to merge 5 commits into from

Conversation

philclifford
Copy link
Member

Goes from 60/hour to 5000/hour for authenticated sessions.

This should hopefully avoid serious deb-getters (and those testing repeatedly 🙌 ) from running into rate-limiting issues too early and often.

philclifford and others added 2 commits August 15, 2022 15:11
@flexiondotorg
Copy link
Member

flexiondotorg commented Aug 18, 2022

Thanks for working on this. Please can you add a few words to README.md about how to use this feature?

@philclifford
Copy link
Member Author

I have added a section to the README. I also spent a day trying to work out why the test workflow is failing (including when essentially the same PR previously passed. (see https://github.com/philclifford/deb-get/actions/runs/2871542877 and friends)
Some of that was what triggered me to work on this (testing failing because all the tests all come from one/very few sources unless you use the provided secret token) . Found some other things that could do with tweaking along the way, which I'll put in another issue, but could not get their ubuntu-latest (?focal !!) runner to pass. Maybe a chat on discord with @OhMyMndy will bear fruit there.

@philclifford
Copy link
Member Author

Somewhere along the line I broke it - I fried my brain with the quoting and inserting

 '--header "Authorization: token $DEBGET_TOKEN"'

into the wget to the api only if set and without the whole lump rejected as an unknown parameter .... resorting to the array seemed to fix it but now It looks like I've been using old cache entries from previous tests/installs and silent wgets have masked the fact that they're not running at all ....

echoing the array and running it by hand works a treat so it is close, but no ${\""\"'cigar}

and since I am over the rate-limit this is also just-in-time
@philclifford philclifford marked this pull request as ready for review August 19, 2022 00:10
@philclifford
Copy link
Member Author

replaced by #457

@philclifford philclifford deleted the auth-github branch November 21, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants