Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to external repositories, bash completion and other quality of life improvements #523

Merged
merged 97 commits into from
Oct 28, 2022

Conversation

natanjunges
Copy link
Contributor

@natanjunges natanjunges commented Sep 16, 2022

Implemented features:

  • External package repositories (implements Support external repositories and move supported packages to one #313)
  • Bash completion (implements Shell completion #465)
  • Deprecated packages handling, warning about them when installed (mentioned at geforcenow-electron dropped support for deb packages #295)
  • Optimized and filtered versions of the list command (--raw, --installed and --not-installed)
  • Filter outputs of prettylist and csvlist by package repository (reverts and fixes Add reminder to move custom user includes aside #458)
  • Simpler version of the update command (--repos-only) that only initializes and updates deb-get's external package repositories, without updating apt or looking for updates of installed packages
  • Install/upgrade hooks to initialize/update package repositories
  • Purge hook to remove cache and package repositories
  • Documentation of new features and preparation of existing pertinent documentation to be moved to main package repository
  • Split test workflows that apply to deb-get and to 01-main subfolder

@natanjunges natanjunges marked this pull request as ready for review October 26, 2022 01:37
@flexiondotorg flexiondotorg added enhancement New feature or request hacktoberfest-accepted Hacktoberfest documentation Improvements or additions to documentation labels Oct 26, 2022
Copy link

@lucyllewy lucyllewy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna say LGTM.

@philclifford
Copy link
Member

philclifford commented Oct 26, 2022

I still believe d08c943 breaks us (because 2 APT lists pointing to same repo with two (albeit identical) keys makes apt upset ) - testing in clean VM confirms.

Otherwise LGTM too - bravo!

I'll try and let all the install tests run through somewhere (also on debian) but it is noteworthy that

  • several apps will now fail on kinetic because repos/ppas have not built for kinetic (yet)
    • currently that causes the list and key to be removed - maybe not ideal if there was a happy jammy repo

@natanjunges
Copy link
Contributor Author

I still believe d08c943 breaks us

Yes indeed, but I thought it was better to address that in a separate PR once this one is merged (I'm thinking on a solution with hard links, since they have built-in reference counting, but there might be better ones). Then we can work on the ideas we discussed for apt-like depends, conflicts and replaces as well.

* the "deb-get Tests" passes even though dpkg fails if you look at the log shrug

Where? I only found an ls error, but it is harmless (ideally it should be silenced).

* several apps will now fail on kinetic because repos/ppas have not built for kinetic (yet)

This does not concern this PR, but we will indeed need to address it, ideally before the next release of deb-get.

  * currently that causes the list and key to be removed - maybe not ideal if there was a happy jammy repo

We should also try to come up with a better solution in a separate PR, something in the lines of #603.

@philclifford philclifford mentioned this pull request Oct 26, 2022
3 tasks
This was referenced Oct 26, 2022
@philclifford
Copy link
Member

Yes indeed, but I thought it was better to address that in a separate PR once this one is merged

Fine with that : we should perhaps add a note somewhere that 6.1 users must uninstall 6.1 before installing 7.0

@philclifford
Copy link
Member

Where? I only found an ls error, but it is harmless (ideally it should be silenced).

Sorry - mea culpa. Looks like I was confused (how unusual!) - Only seeing the ls now: I did see a dpkg fail in a test that passed, but was thrashing around in the early hours and mis-remembered after sleeping.

Copy link
Member

@philclifford philclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OhMyMndy
Copy link
Contributor

Really cool to see some big progress on deb-get! One thing, which isn't possible any more, is to just grab the deb-get file from the repo and execute it because it depends on many other files. Reason why I used deb-get like that is to use the version from my pull request because it wasn't merged yet (I wanted to install something with deb-get which was not upstream yet).

This setup resolves that problem by allowing external repo's!

Great work @natanjunges @philclifford @diddledani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest-accepted Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants