Add Ookla official SpeedTest cli client #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philclifford
requested changes
Nov 10, 2023
01-main/README.md
Outdated
| @@ -154,6 +154,7 @@ cog.out(pretty_list) | |||
| | [<img src="../.github/direct.png" align="top" width="20" />](https://www.ocenaudio.com/) | `ocenaudio` | <i>Easy, fast and powerful audio editor.</i> | | |||
| | [<img src="../.github/debian.png" align="top" width="20" />](https://github.com/jstaf/onedriver) | `onedriver` | <i>A native Linux filesystem for Microsoft Onedrive.</i> | | |||
| | [<img src="../.github/github.png" align="top" width="20" />](https://www.onlyoffice.com/en/desktop.aspx) | `onlyoffice-desktopeditors` | <i>Free desktop office suite for document editing and collaboration.</i> | | |||
| | [<img src="../.github/debian.png" align="top" width="20" />](https://www.speedtest.net/) | `ookla-speedtest` | <i>Official Linux-native Speedtest application backed by Ookla.</i> | | |||
There was a problem hiding this comment.
The README.md is to be updated by maintainers only via cog. See 01-main/CONTRIBUTING.md (Sorry the top-level CONTRIBUTING.md needs correcting)
Please remove changes to the README as it avoids some spurious merge conflicts.
01-main/manifest
Outdated
| @@ -153,6 +153,7 @@ ocenaudio | |||
| tezos-baking | |||
| onedriver | |||
| onlyoffice-desktopeditors | |||
| ookla-speedtest | |||
There was a problem hiding this comment.
The CI test fails because ookla-speedtest is not found : the name we use (in manifest and the package filename) must match the app exactly. You need to use speedtest
01-main/packages/ookla-speedtest
Outdated
| @@ -0,0 +1,7 @@ | |||
| DEFVER=1 | |||
| ASC_KEY_URL="https://packagecloud.io/ookla/speedtest-cli/gpgkey" | |||
| APT_LIST_NAME="speedtest" | |||
There was a problem hiding this comment.
only needed where one repository hosts several apps, in which case we need this to align all to one list and key. If you don't need it then omit it.
PeterDaveHello
force-pushed
the
ookla_speedtest
branch
2 times, most recently
from
55a7dcb
to
8785473
Compare
PeterDaveHello
force-pushed
the
ookla_speedtest
branch
from
8785473
to
0738d02
Compare
|
@philclifford I revised it with all the suggestions, and the CI passed. Thanks! |
philclifford
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR here, hope it good enough to be accepted ;)