feat: display last key renewal attempt #3839
Conversation
Deploying windmill with
|
| Latest commit: |
f2f7110
|
| Status: | ⚡️ Build in progress... |
HugoCasa
force-pushed
the
hc/key-renewal-status
branch
from
5d24fd8 to
d55e5e5
Compare
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to a279a26 in 1 minute and 25 seconds
More details
- Looked at
407lines of code in9files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_lJGTFz8c8ReIPt57
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ad72277 in 1 minute and 24 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. backend/windmill-common/src/ee.rs:32
- Draft comment:
Returning an empty string fromrenew_license_keyprovides no information about the success or failure of the operation. Consider returning a result or a more descriptive status message.
"License renewal operation completed".to_string()
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_oFNDPR1Qr4NbYjhd
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on f2f7110 in 1 minute and 24 seconds
More details
- Looked at
49lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. backend/parsers/windmill-parser-ts/Cargo.toml:19
- Draft comment:
Thetriomphepackage version is implicitly set to workspace version which might conflict with the explicit downgrade to<0.1.12in the mainCargo.toml. Consider aligning the version across all projects to avoid potential build issues. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_sVjmHaMbGAGPtgb9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Summary:
This PR adds functionality to display the last key renewal attempt and provides an endpoint to renew the license key, with updates across backend and frontend components, including a necessary package downgrade.
Key points:
/settings/latest_key_renewal_attemptand/settings/renew_license_key.backend/windmill-api/src/settings.rswith new handlers.backend/windmill-common/src/ee.rsfor license key renewal logic.frontend/src/lib/components/InstanceSettings.svelteto display last key renewal attempt and provide a button to initiate renewal.frontend/src/lib/components/instanceSettings.tsfor new features.triomphepackage inbackend/Cargo.tomlandbackend/parsers/windmill-parser-ts/Cargo.tomldue to a broken version.Generated with ❤️ by ellipsis.dev