feat: chart interactivity: click points on the graph to select the corresponding jobs #3851
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 87bdace in 1 minute and 43 seconds
More details
- Looked at
286lines of code in4files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/lib/components/RunChart.svelte:144
- Draft comment:
ThehighlightSelectedPointsfunction modifies thedataobject directly, which might not trigger a re-render in Svelte. Consider using an assignment todataor a specific reactive statement to ensure UI updates. - Reason this comment was not posted:
Confidence of 30% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_ouYtsevyIcu768NV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Deploying windmill with
|
| Latest commit: |
5c7b8e9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6941cb38.windmill.pages.dev |
| Branch Preview URL: | https://win-166-chart-interactivity.windmill.pages.dev |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b4d7590 in 6 minutes and 25 seconds
More details
- Looked at
22lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_WVzPJzsSsyhiie5K
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 5c7b8e9 in 5 minutes and 18 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_lfi3hT7Go4MrHTtR
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Summary:
Enhanced the
RunChart.sveltecomponent to support interactive multiple job selections with dynamic visual feedback and updated interaction handling.Key points:
selectedIdtoselectedIdsallowing multiple selections.RunChart.svelteto support multiple job selections by clicking on graph points.backgroundColorin datasets to dynamically change based on selection.highlightSelectedPointsfunction to handle point highlighting and dynamically change point colors based on selection.onClickevent to updateselectedIdsbased on user interaction.Generated with ❤️ by ellipsis.dev