feat(frontend): improve table action UX #4056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 11f4907 in 54 seconds
More details
- Looked at
293lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_8ObfrhQDdDX54aAa
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
frontend/src/lib/components/apps/editor/settingsPanel/ComponentPanel.svelte
Outdated
Show resolved
Hide resolved
Deploying windmill with
|
| Latest commit: |
68806be
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89952994.windmill.pages.dev |
| Branch Preview URL: | https://fr-improve-table-actions-ux.windmill.pages.dev |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 68806be in 32 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/lib/components/apps/editor/settingsPanel/ComponentPanel.svelte:203
- Draft comment:
The removal oftarget="_blank"is appropriate here as it aligns with the PR's intent to improve internal navigation without opening new tabs. - Reason this comment was not posted:
Confidence changes required:0%
The removal of thetarget="_blank"attribute from the Button component inside the Popover inComponentPanel.svelteseems intentional as per the PR description, which mentions improving navigation to return to the table configuration from the table action configuration. This change likely aims to keep the navigation within the same tab rather than opening a new one, which aligns with the PR's goal of improving user experience within the application's settings panel.
Workflow ID: wflow_17dAfrVpaVl1qpxa
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-07-10.at.11.37.01.mov
Summary:
Enhanced table action UX with reordering, navigation to table config, and added documentation.
Key points:
GridTabinfrontend/src/lib/components/apps/editor/settingsPanel/TableActions.svelte.frontend/src/lib/components/apps/editor/settingsPanel/ComponentPanel.svelte.frontend/src/lib/components/apps/editor/settingsPanel/ComponentPanel.svelte.isTableActionfunction infrontend/src/lib/components/apps/editor/appUtils.tsto check if an action belongs to a table component.frontend/src/lib/components/apps/editor/settingsPanel/ComponentPanel.svelteandfrontend/src/lib/components/apps/editor/settingsPanel/TableActions.svelte.Generated with ❤️ by ellipsis.dev