feat(frontend): add support for GFM and fix max-width issue #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to cc2ed04 in 36 seconds
More details
- Looked at
67lines of code in3files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/lib/components/apps/components/display/AppMarkdown.svelte:91
- Draft comment:
The PR lacks a description and comments explaining the introduction of GitHub Flavored Markdown support and the reasoning behind these changes. It's important to document the intent and context behind significant modifications to help reviewers understand the changes and ensure they align with the project's goals. - Reason this comment was not posted:
Confidence changes required:33%
The PR introduces support for GitHub Flavored Markdown (GFM) in theAppMarkdown.sveltecomponent by conditionally adding thegfmPluginbased on theGithubFlavoredMarkdownEnabledconfiguration. However, the PR description and comments are empty, which doesn't provide context or reasoning behind the changes, especially the introduction of GFM support. This is important for understanding the intent and ensuring that the changes align with project goals or user needs.
Workflow ID: wflow_62UkKqF6NYVhkQ9N
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Deploying windmill with
|
| Latest commit: |
ebded30
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://72d5a781.windmill.pages.dev |
| Branch Preview URL: | https://fr-improve-markdown-componen.windmill.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added support for GitHub Flavored Markdown, fixed max-width issue, and removed
GithubFlavoredMarkdownEnabledconfiguration option in Markdown component.Key points:
svelte-exmarkdowndependency infrontend/package.jsonto^3.0.5.gfmPluginfromsvelte-exmarkdown/gfminfrontend/src/lib/components/apps/components/display/AppMarkdown.svelte.Markdowncomponent inAppMarkdown.svelteto usegfmPlugin.max-w-fullclass to Markdown container inAppMarkdown.svelteto fix max-width issue.GithubFlavoredMarkdownEnabledconfiguration option fromMarkdownComponentinfrontend/src/lib/components/apps/editor/component/components.ts.Generated with ❤️ by ellipsis.dev