Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix run page ms readability #4059

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

fatonramadani
Copy link
Contributor

@fatonramadani fatonramadani commented Jul 10, 2024

Screenshot 2024-07-10 at 17 10 09 Screenshot 2024-07-10 at 17 12 49
🚀 This description was created by Ellipsis for commit c0424b6

Summary:

Improved run duration readability by changing the display format from seconds to a more human-readable format in the frontend.

Key points:

  • Changed: frontend/src/lib/components/DurationMs.svelte to use msToReadableTime instead of msToSec for displaying run duration.
  • Changed: frontend/src/lib/components/runs/RunRow.svelte to use msToReadableTime instead of msToSec for displaying run duration.
  • Added: msToReadableTime function in frontend/src/lib/utils.ts to convert milliseconds to a human-readable format (days, hours, minutes, seconds).

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c0424b6 in 32 seconds

More details
  • Looked at 86 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/lib/utils.ts:116
  • Draft comment:
    The implementation of msToReadableTime correctly handles undefined inputs and formats durations into a more readable string. This change should enhance the user interface by providing clearer duration displays.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR aims to improve the readability of duration display by using a more human-readable format. The msToReadableTime function is introduced to replace msToSec. This function formats milliseconds into a more readable string format like '1d 2h 3m 4s' depending on the duration. The changes are applied in two Svelte components where durations are displayed. The PR seems to correctly replace the usage of msToSec with msToReadableTime in both components. The function itself handles undefined inputs and formats the time correctly based on the duration. Overall, the changes are consistent with the goal of improving readability.

Workflow ID: wflow_Tc0oczSxdZZ6OSZ0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: c0424b6
Status: ✅  Deploy successful!
Preview URL: https://d83a93fe.windmill.pages.dev
Branch Preview URL: https://fr-improve-ms-readability.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel merged commit 0b932ca into main Jul 10, 2024
3 checks passed
@rubenfiszel rubenfiszel deleted the fr/improve-ms-readability branch July 10, 2024 17:05
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants