Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add indexer case to avoid 0 max_database_connection #4073

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

wendrul
Copy link
Contributor

@wendrul wendrul commented Jul 12, 2024

🚀 This description was created by Ellipsis for commit 4fe25f3

Summary:

Added indexer_mode handling to set default max database connections for indexers in connect_db function.

Key points:

  • Modified backend/src/main.rs to pass indexer_mode to connect_db.
  • Updated connect_db function in backend/windmill-common/src/lib.rs to handle indexer_mode.
  • Added DEFAULT_MAX_CONNECTIONS_INDEXER constant in backend/windmill-common/src/lib.rs.
  • Handled case where indexer_mode sets max database connections to DEFAULT_MAX_CONNECTIONS_INDEXER.

Generated with ❤️ by ellipsis.dev

@wendrul wendrul requested a review from rubenfiszel as a code owner July 12, 2024 21:25
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4fe25f3 in 45 seconds

More details
  • Looked at 62 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. backend/windmill-common/src/lib.rs:189
  • Draft comment:
    The PR introduces a new parameter indexer_mode to the connect_db function and modifies the call in backend/src/main.rs to pass this new parameter. Ensure that the handling or initialization of indexer_mode in backend/src/main.rs is correctly set up to reflect this change.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_FUw8ffAay0sS8cZZ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4fe25f3
Status: ✅  Deploy successful!
Preview URL: https://62ebe1aa.windmill.pages.dev
Branch Preview URL: https://win-243-indexer-fixes-2.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel merged commit 0a886e0 into main Jul 12, 2024
3 checks passed
@rubenfiszel rubenfiszel deleted the win-243-indexer-fixes-2 branch July 12, 2024 22:18
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants