-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multi-language support(Chinese, English and French) to static text in .xaml #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not necessary.
<DesignTime>True</DesignTime> | ||
<DependentUpon>lang.resx</DependentUpon> | ||
</Compile> | ||
<Compile Include="Properties\i18n\lang.zh-CN.Designer.cs"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lang.zh-CN.Designer.cs
is not necessary.
<DesignTime>True</DesignTime> | ||
<DependentUpon>lang.zh-CN.resx</DependentUpon> | ||
</Compile> | ||
<Compile Include="Properties\i18n\lang.fr-FR.Designer.cs"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lang.fr-FR.Designer.cs
is not necessary.
@@ -37,7 +38,8 @@ | |||
</MultiBinding> | |||
</ui:ProgressBar.Visibility> | |||
</ui:ProgressBar> | |||
<TextBlock FontSize="48" FontFamily="Century Gothic" HorizontalAlignment="Center">elaphureLink</TextBlock> | |||
<TextBlock FontSize="48" FontFamily="Century Gothic" HorizontalAlignment="Center" Text="{x:Static language:lang.elaphureLink}"></TextBlock> | |||
<TextBlock FontSize="16" FontFamily="Century Gothic" HorizontalAlignment="Center" Text="{x:Static language:lang.keilWirelessProxy}"></TextBlock> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a slogan! It would be nice if all language translations were added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me! I will make some modifications and merge it. 😀
Modifications have been merged in. Thank you for your contribution😀 |
Hi again, I put the vcproj file, and restored the empty Ressources.resx(+Ressources.Designer.cs) files.
The action job ran successfully in my forked repository.
I didn't test the default(on application open) localization behavior for other languages(French and English).
I added a little description "Keil 无线透传" in Chinese lang bellow the "elaphureLink" title on the homePage.
You can remove it, by removing the added line in the HomePage.xaml.