feat: add multi-language support(Chinese, English and French) to static text in .xaml #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windowsair
reviewed
Oct 7, 2023
windowsair
reviewed
Oct 7, 2023
windowsair
reviewed
Oct 7, 2023
| <DesignTime>True</DesignTime> | ||
| <DependentUpon>lang.resx</DependentUpon> | ||
| </Compile> | ||
| <Compile Include="Properties\i18n\lang.zh-CN.Designer.cs"> |
There was a problem hiding this comment.
lang.zh-CN.Designer.cs is not necessary.
windowsair
reviewed
Oct 7, 2023
| <DesignTime>True</DesignTime> | ||
| <DependentUpon>lang.zh-CN.resx</DependentUpon> | ||
| </Compile> | ||
| <Compile Include="Properties\i18n\lang.fr-FR.Designer.cs"> |
There was a problem hiding this comment.
lang.fr-FR.Designer.cs is not necessary.
windowsair
reviewed
Oct 7, 2023
| @@ -37,7 +38,8 @@ | |||
| </MultiBinding> | |||
| </ui:ProgressBar.Visibility> | |||
| </ui:ProgressBar> | |||
| <TextBlock FontSize="48" FontFamily="Century Gothic" HorizontalAlignment="Center">elaphureLink</TextBlock> | |||
| <TextBlock FontSize="48" FontFamily="Century Gothic" HorizontalAlignment="Center" Text="{x:Static language:lang.elaphureLink}"></TextBlock> | |||
| <TextBlock FontSize="16" FontFamily="Century Gothic" HorizontalAlignment="Center" Text="{x:Static language:lang.keilWirelessProxy}"></TextBlock> | |||
There was a problem hiding this comment.
Looks like a slogan! It would be nice if all language translations were added.
windowsair
reviewed
Oct 7, 2023
|
Modifications have been merged in. Thank you for your contribution😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again, I put the vcproj file, and restored the empty Ressources.resx(+Ressources.Designer.cs) files.
The action job ran successfully in my forked repository.
I didn't test the default(on application open) localization behavior for other languages(French and English).
I added a little description "Keil 无线透传" in Chinese lang bellow the "elaphureLink" title on the homePage.
You can remove it, by removing the added line in the HomePage.xaml.