feat(esp32s3) add support for esp32s3 #72
Conversation
|
Thanks for your contribution! I will review your code later :) |
components/DAP/config/DAP_config.h
Outdated
| #elif defined CONFIG_IDF_TARGET_ESP32S3 | ||
| __STATIC_INLINE void PORT_JTAG_SETUP(void) | ||
| { | ||
| // set TCK, TMS pin |
README_CN.md
Outdated
There was a problem hiding this comment.
mine is lf, and it was crlf
components/DAP/source/spi_op.c
Outdated
| @@ -30,6 +30,8 @@ | |||
| #define DAP_SPI SPI2 | |||
| #elif defined CONFIG_IDF_TARGET_ESP32C3 | |||
| #define DAP_SPI GPSPI2 | |||
| #elif defined CONFIG_IDF_TARGET_ESP32S3 | |||
| #define DAP_SPI GPSPI2 | |||
components/DAP/source/spi_switch.c
Outdated
| @@ -18,6 +18,7 @@ | |||
| #include "components/DAP/include/cmsis_compiler.h" | |||
| #include "components/DAP/include/spi_switch.h" | |||
| #include "components/DAP/include/gpio_common.h" | |||
| #include "DAP_config.h" | |||
There was a problem hiding this comment.
I used the definitions like PIN_SWDIO_MOSI from DAP_config.h, you are right that IOMUX pins are fixed anyway, it will cause error if user change the pin from DAP_config.h. I will change that.
components/DAP/source/spi_switch.c
Outdated
| #elif defined CONFIG_IDF_TARGET_ESP32S3 | ||
| void DAP_SPI_Init() | ||
| { | ||
| periph_ll_enable_clk_clear_rst(PERIPH_SPI2_MODULE); |
main/wifi_handle.c
Outdated
| @@ -23,6 +23,8 @@ | |||
| #define PIN_LED_WIFI_STATUS 27 | |||
| #elif defined CONFIG_IDF_TARGET_ESP32C3 | |||
| #define PIN_LED_WIFI_STATUS 10 | |||
| #elif defined CONFIG_IDF_TARGET_ESP32S3 | |||
| #define PIN_LED_WIFI_STATUS 4 | |||
|
Looks really good. I have a few comments related to coding style. These are hopefully minor things that should be relatively trivial to change. You can try to change them. If you don't feel like it, I might see if I can hijack this branch and make these changes for you. Thanks a lot for your contributions to this project. |
People who uses spaces are 👿. 😛 |
|
It seems that there are no major changes to the esp32s3 spi controller, that's good. I'll merge this. Thanks again for your contribution to this project. |
Tested on Windows Keil uVision 5.38.0.
ESP32S3-WROOM-1-N16R8
Target: stm32f103c8t8
Port used: SWD