Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary/invalid plugins in tests/minimal_init.lua #203

Closed
PriceHiller opened this issue Jul 14, 2024 · 0 comments · Fixed by #204
Closed

Remove unnecessary/invalid plugins in tests/minimal_init.lua #203

PriceHiller opened this issue Jul 14, 2024 · 0 comments · Fixed by #204
Assignees
@PriceHiller
Labels
good first issue Good for newcomers

Comments

@PriceHiller
Copy link
Collaborator

See

nvim-ts-autotag/tests/minimal_init.lua

Lines 139 to 144 in 323a3e1

M.setup({
["plenary.nvim"] = "https://github.com/nvim-lua/plenary.nvim",
["popup.nvim"] = "https://github.com/nvim-lua/popup.nvim",
["nvim-treesitter"] = "https://github.com/nvim-treesitter/nvim-treesitter",
["playground"] = "https://github.com/nvim-treesitter/playground",
})

For instance, is popup.nvim really necessary?
@PriceHiller PriceHiller self-assigned this Jul 14, 2024
@PriceHiller PriceHiller added the good first issue Good for newcomers label Jul 14, 2024
PriceHiller added a commit that referenced this issue Jul 14, 2024
@PriceHiller
test(refactor): remove invalid test plugins
95fa31d 
- `popup.nvim` is not referenced anywhere within the plugin and as such
  should be removed.
- `playground` is not needed either, it's not referenced and secondly
  the most important feature from it (:TSPlayground) is covered by
  Neovim's :InspectTree command in more recent versions of Neovim.

Closes #203 (#203)
@PriceHiller PriceHiller mentioned this issue Jul 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PriceHiller PriceHiller

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(refactor): remove invalid test plugins windwp/nvim-ts-autotag
1 participant
@PriceHiller