Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call setup instead of init #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: call setup instead of init #213

wants to merge 1 commit into from

Conversation

ofseed
Copy link

@ofseed ofseed commented Sep 11, 2024

Though init will be deprecated, it is called automatically when this plugin is loaded, causing loading nvim-treesitter, which is no longer needed now.

@PriceHiller
Copy link
Collaborator

Thanks for the PR!

This means the user can't pass a custom config to setup AFAIK -- probably not the right way to shim out nvim-treesitter.

I'm game to retire the entire nvim-treesitter module stuff though, that deprecation notice has been out for a while so a breaking change at this point isn't a huge deal.

I won't take this PR as is, but if you want to yank nvim-treesitter out here's what you can do:

  1. Remove the entire plugin/ directory as it won't be useful anymore
  2. Remove the notice about nvim-treesitter in the README here
  3. Remove the setup check in attach for nvim-treesitter here
  4. Remove the init function for nvim-treesitter here

If you want to create a new PR with those changes or modify on top of your current one, I'll gladly accept it with those changes made. This should also result in nvim-treesitter not being loaded anymore.

@ofseed
Copy link
Author

ofseed commented Sep 12, 2024

Would it be better to remove from plugin/nvim-autotag.lua to after/plugin/nvim-autotag.lua? This should make sure users' setup is loaded before our setup.

@PriceHiller
Copy link
Collaborator

Totally missed your response!

Would it be better to remove from plugin/nvim-autotag.lua to after/plugin/nvim-autotag.lua? This should make sure users' setup is loaded before our setup.

Sure, you can do that, it's a good idea. We would still need to remove all the nvim-treesitter stuff as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants