Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename License.txt to LICENSE.txt #60

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Rename License.txt to LICENSE.txt #60

merged 1 commit into from
Jul 1, 2021

Conversation

sometimesfood
Copy link
Contributor

This pull request renames License.txt to LICENSE.txt so the license is included in the module zip file.

Apparently, the golang team does not intend to change what files are included in the zip file:
golang/go#43817 (comment)

@billziss-gh
Copy link
Collaborator

@sometimesfood I am unclear on the reasons for renaming the license. Can you please explain the rationale?

@sometimesfood
Copy link
Contributor Author

sometimesfood commented Jun 26, 2021

Sorry for the confusion, I should have done so earlier.

When importing cgofuse and using go mod vendor, the license file is not distributed with the code because it is not included in the module zip file. This seems to be due to the file name of the license file.

If I import the package github.com/billziss-gh/cgofuse/fuse and use go mod vendor to download a copy of the sources to my vendor directory, the directory vendor/github.com/billziss-gh/cgofuse/ does not contain a copy of the license file.

For comparison: If I import github.com/hashicorp/golang-lru/simplelru, the directory vendor/github.com/hashicorp/golang-lru/ contains a copy of the LICENSE file.

I am not sure why that is, but the golang repo comment linked above indicates it might be due to the file name of the license file in your repo.

@sometimesfood
Copy link
Contributor Author

sometimesfood commented Jun 26, 2021

Btw, just to be clear: Renaming the license file, adding a new version tag and importing the resulting version from a private repo works just as expected and the license file is included correctly in the module zip file and the vendor directory.

@billziss-gh
Copy link
Collaborator

Thank you for the explanation. I will merge this in.

@billziss-gh billziss-gh merged commit a12da0f into winfsp:master Jul 1, 2021
@sometimesfood
Copy link
Contributor Author

Great, thanks!

@sometimesfood sometimesfood deleted the rename-license branch July 1, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants