-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo organization: move tests out of examples
#5992
Comments
Adding on an idea - I think it would be nice if all packages (including TypeScript-based and Rust-based ones) were in the same directory, |
If we move the
I'm cool with this, If we combine everything we could also start respecting the convention of a hierarchy the matches the package name. i.e. wingsdk would be in |
Agree, I think we can gracefully archive them to git history (or keep them as a fun historical artifact somewhere on the |
+1 on |
Summarizing the actions specified in this issue, for any happy contributor out there who wants to pick this up:
|
Archived to... git history. Related to #5992 ## Checklist - [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [ ] Description explains motivation and solution - [ ] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Can I work on this? |
But of course @govindplal :) |
This is what I understood is to be done : @staycoolcall911 Can someone confirm this |
Yes indeed @govindplal - you got it right |
also, please take a look at where we use |
Yeah, sure. Got held up with something else for the past days. I'm working on it! |
Hi @govindplal I am trying to reach out through Discord - I could not see you there, do you want to join to we can continue the discussion there? https://t.winglang.io/discord |
Hi, This issue hasn't seen activity in 90 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days. |
Congrats! 🚀 This was released in Wing 0.83.11. |
Currently all of our tests are under
/examples/tests
. That's a bit weird.Can we just move them to
/tests
?The text was updated successfully, but these errors were encountered: