Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): turbo caching improvements and minor packaging simplification #3913

Merged
merged 16 commits into from
Aug 23, 2023

Conversation

MarkMcCulloh
Copy link
Contributor

Subset of changes from #3791, avoiding the titular "skip hangar" part.

Primary Goal: Tweak turbo configuration to both more granular and more accurate in general

Changes:

  • (turbo) Tests do not effect compile/package output
  • (turbo) Stop using src/** when possible, using more specific file extensions
  • Make wingc.wasm and docs.tgz part of npm scripts and put the result alongside the other distributables
    • the github workflow was simplified to be able to just upload/download all these dists
  • (workflow) Made sure rust only caches in the test workflow, otherwise the build and test workflows fight over the cache
  • Fixed Ensure NPM packages are published in the correct order #3842 by explicitly publishing packages in order. Might do something more robust later, but this at least avoids the out-of-order issue
  • Deleted several extra license files (projen generated a LICENSE, while we had LICENSE.md as well)

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2023

Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/turbo-tweaks-2 is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Aug 22, 2023
MarkMcCulloh and others added 2 commits August 22, 2023 20:13
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 23, 2023
@MarkMcCulloh MarkMcCulloh removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 23, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023

Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/turbo-tweaks-2 is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Aug 23, 2023
@mergify mergify bot merged commit b547c18 into main Aug 23, 2023
11 checks passed
@mergify mergify bot deleted the mark/turbo-tweaks-2 branch August 23, 2023 12:25
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.25.35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure NPM packages are published in the correct order
3 participants