Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add bucketDomainName to IAwsBucket and BucketRef #7207

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

ShaiBer
Copy link
Contributor

@ShaiBer ShaiBer commented Oct 29, 2024

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@ShaiBer ShaiBer requested a review from a team as a code owner October 29, 2024 12:15
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping use over Discord.

@ShaiBer ShaiBer requested a review from eladb October 29, 2024 12:16
@monadabot
Copy link
Contributor

monadabot commented Oct 29, 2024

Console preview environment is available at https://wing-console-pr-7207.fly.dev 🚀

Last Updated (UTC) 2024-10-29 12:33

Signed-off-by: monada-bot[bot] <monabot@monada.co>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 29, 2024
@ShaiBer ShaiBer changed the title feat(sdk) add bucketDomainName to IAwsBucket and BucketRef feat(sdk): add bucketDomainName to IAwsBucket and BucketRef Oct 29, 2024
@ShaiBer ShaiBer merged commit e37b943 into main Oct 29, 2024
13 of 14 checks passed
@ShaiBer ShaiBer deleted the add-bucket-domain-name branch October 29, 2024 13:44
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.85.27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants