Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debugging ci workflows, don't merge #7252

Closed
wants to merge 21 commits into from
Closed

Conversation

skyrpex
Copy link
Contributor

@skyrpex skyrpex commented Jan 27, 2025

No description provided.

Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping use over Discord.

@monadabot
Copy link
Contributor

monadabot commented Jan 27, 2025

Console preview environment is available at https://wing-console-pr-7252.fly.dev 🚀

Last Updated (UTC) 2025-01-27 14:19

@monadabot
Copy link
Contributor

monadabot commented Jan 27, 2025

Benchmarks

Comparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 60ms±0.8 57ms±0.46 -3ms (-5.23%)⬜
hello_world.test.w -t sim 420ms±3.96 439ms±26.21 +18ms (+4.39%)🟥
hello_world.test.w -t tf-aws 1529ms±16.4 1516ms±11.26 -13ms (-0.85%)⬜
jsii_big.test.w -t sim 3014ms±12.66 3000ms±16.61 -14ms (-0.46%)⬜
jsii_big.test.w -t tf-aws 3239ms±11.27 3227ms±14.5 -12ms (-0.36%)⬜
jsii_small.test.w -t sim 391ms±6.46 395ms±3.01 +4ms (+1.02%)⬜
jsii_small.test.w -t tf-aws 618ms±5.44 625ms±2.74 +7ms (+1.1%)⬜
empty.test.w -t sim 382ms±3.34 381ms±3.24 -1ms (-0.32%)⬜
empty.test.w -t tf-aws 614ms±6 619ms±4.64 +5ms (+0.81%)⬜
functions_10.test.w -t sim 508ms±15.94 515ms±13.71 +8ms (+1.48%)⬜
functions_10.test.w -t tf-aws 2254ms±17.33 2281ms±51.3 +27ms (+1.21%)⬜
functions_1.test.w -t sim 411ms±6.57 416ms±6.67 +5ms (+1.16%)⬜
functions_1.test.w -t tf-aws 852ms±6.37 868ms±5.63 +16ms (+1.88%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 57ms 56ms 58ms 0ms 1ms
hello_world.test.w -t sim 439ms 410ms 527ms 26ms 37ms
hello_world.test.w -t tf-aws 1516ms 1485ms 1545ms 11ms 16ms
jsii_big.test.w -t sim 3000ms 2959ms 3030ms 17ms 23ms
jsii_big.test.w -t tf-aws 3227ms 3206ms 3274ms 15ms 20ms
jsii_small.test.w -t sim 395ms 389ms 401ms 3ms 4ms
jsii_small.test.w -t tf-aws 625ms 619ms 632ms 3ms 4ms
empty.test.w -t sim 381ms 373ms 389ms 3ms 5ms
empty.test.w -t tf-aws 619ms 612ms 632ms 5ms 6ms
functions_10.test.w -t sim 515ms 482ms 551ms 14ms 19ms
functions_10.test.w -t tf-aws 2281ms 2235ms 2472ms 51ms 72ms
functions_1.test.w -t sim 416ms 403ms 437ms 7ms 9ms
functions_1.test.w -t tf-aws 868ms 855ms 883ms 6ms 8ms
Last Updated (UTC) 2025-01-27 10:45

@skyrpex skyrpex changed the title debugging ci workflows, don't merge fix: debugging ci workflows, don't merge Jan 27, 2025
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jan 27, 2025
@monadabot
Copy link
Contributor

❌ Unstable Self-Mutation ❌

Self-mutation has run twice in a row. There may be a something non-deterministic in the build or test process.
Check the last mutation commit (7646f4e) for suspicious changes.
This is typically caused by:

  • Absolute paths
  • Timestamps
  • Random values
  • Flakey tests (relying on one of the above)

@skyrpex skyrpex force-pushed the debug-ci-workflows branch from 7646f4e to 5b08395 Compare January 27, 2025 12:11
@skyrpex skyrpex closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 pr/e2e-full ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants