-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated webpack to v2 #42
Conversation
Now using babel-preset-env Added loaders for images and fonts We can now use the latest docs for webpack ~ 2.6.0
Nothing too important
frontend/package.json
Outdated
@@ -40,9 +40,9 @@ | |||
}, | |||
"scripts": { | |||
"test": "echo \"Error: no test specified\" && exit 1", | |||
"build": "webpack --config webpack.config.js", | |||
"watch": "webpack --config webpack.config.js --watch", | |||
"build": "webpack", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change this? Is webpack.config.js a config name by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is. I also added a webpack-dev-server plugin instead of the http-server which works much better with hot-reloading the page. ( I will commit that very soon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But do not forget to leave http-server and npm run start for "production" ;)
frontend/webpack.config.js
Outdated
}), | ||
|
||
new HtmlWebpackPlugin({ | ||
template: path.resolve(__dirname,'src/index.html') | ||
title: 'Testing', | ||
template: path.resolve(__dirname, 'src/index.html') | ||
}), | ||
|
||
new ExtractTextPlugin("styles/[name].css"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is bugged also. Change to new ExtractTextPlugin("[name].css")
please. Otherwise, it creates bad img links. webpack-contrib/extract-text-webpack-plugin#27 (comment)
Maybe there is a "wiser" solution but only this helped me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, will do now.
frontend/package.json
Outdated
}, | ||
"author": "Adrian Hernandez-Mendez <adrian.hernandez@tum.de>", | ||
"author": "SEBA-TEAM-24", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be more correct to say SEBA Team #25 & Adrian Hernandez-Mendez <adrian.hernandez@tum.de>
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, changing... but we're team 24 :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, 24, my fault xD
* Fix webpack image processing * Update toolbar style and add landing header * Add overview and pricing landing sections * Unstick footer and add icon credits
Now using babel-preset-env Added loaders for images and fonts We can now use the latest docs for webpack ~ 2.6.0
frontend/package.json
Outdated
"prestart": "npm install", | ||
"start": "http-server -a localhost -p 8000 -c-1 ./dist" | ||
"start": "http-server -a localhost -p 8000 -c-1 ./dist", | ||
"dev-server": "webpack-dev-server --progress --open" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imho start-dev
will be more cohere with previous "prod" one (start).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update README.md with info how to start dev server
Added a default port for the node server: 8080 Updated the README.md
* Updated webpack to v2 Now using babel-preset-env Added loaders for images and fonts We can now use the latest docs for webpack ~ 2.6.0 * Minor changes to package.json Nothing too important * Updated webpack to v2 Now using babel-preset-env Added loaders for images and fonts We can now use the latest docs for webpack ~ 2.6.0 * Implement landing page (#43) * Fix webpack image processing * Update toolbar style and add landing header * Add overview and pricing landing sections * Unstick footer and add icon credits * Updated package.json and webpack.config.js * Updated backend package.json Added a default port for the node server: 8080 Updated the README.md
Now using babel-preset-env
Added loaders for images and fonts
We can now use the latest docs for webpack ~ 2.6.1