Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fix a very occasional crash bug. #73

Merged
merged 8 commits into from
Sep 29, 2018
Merged

[fix] fix a very occasional crash bug. #73

merged 8 commits into from
Sep 29, 2018

Conversation

HeyJupiter
Copy link
Contributor

Hey guy, I found my nginx crashed very occasionally under the high load environment in the last few days but always got SIGSEGV signal in ngx_rtmp_gop_cache_free_frame.
It took me so much time to find out that some variables was allocated in a pool but chains another pool, right? So, if pool was destroyed but variables in the pool were still referred to by chains, that would lead to a crash.

HeyJupiter and others added 8 commits August 31, 2018 11:57
* [dev] optimize GOP cache feature. (#66)

* [dev] make config file more compatible.

* [dev] optimize GOP cache feature.

* [dev] support for onTextData and onCuePoint (#68).

* [dev] fix code style flaws.

* [misc] fix a potential crash bug, remove unused codes and update version.
[dev] sync from winshining/master.
@winshining winshining merged commit 9f2d5af into winshining:master Sep 29, 2018
@winshining
Copy link
Owner

Great! That is a real deep-hidden bug! Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants