-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransformableInfo Typing out of date. #111
Comments
Yep, running into the same, although I fixed this without casting by just adding the splat to the interface: import { SPLAT } from 'triple-beam';
declare module 'logform' {
export interface TransformableInfo {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
[SPLAT]: any;
}
} |
dscalzi
added a commit
to dscalzi/logform
that referenced
this issue
Oct 6, 2020
Any plans to merge this PR? Running into this issue as well. |
@yurijmikhalevich can this be given some attention? Still a problem over a year later and it's causing a big headache getting tsc to work on gh-actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
TransformableInfo
key is no longer restricted to only a string.triple-beam
changed their typings such that the constants are no longer strings.see triple-beam change: DefinitelyTyped/DefinitelyTyped#46490
usage in winston: https://github.com/winstonjs/winston/blob/68ea786e053e50b51396e0cc8993c67ff789609c/lib/winston/logger.js#L251
Location of required change: https://github.com/winstonjs/logform/blob/master/index.d.ts#L10
TL;DR the type needs to support strings and
unique symbol
.Current ugly workaround for projects using these typings:
The text was updated successfully, but these errors were encountered: