fix: avoid dynamic requires #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid dynamic requires to be able to bundle projects in one file (with `parcel build index.js --bundle-node-modules` for example). Can be useful for lambda functions.
|
FWIW this PR would also make logform usable with the esbuild bundler too. This PR removes the lazy evaluation aspect so it's not equivalent to the current code. However, you can avoid dynamic require while still keeping the lazy evaluation aspect if you would like. See evanw/esbuild#480 (comment) for an example of how to do this. |
|
This looks like a pretty safe change but a major blocker for some folks. @DABH Is there anything we can help with to get this merged? |
|
I created #117 , which retains the lazy behavior |
|
Closed in favor of #117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid dynamic requires to be able to bundle projects in one file (with
parcel build index.js --bundle-node-modulesfor example). Can be useful for lambda functions.