Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add two tls options #207

Merged
merged 1 commit into from
Sep 19, 2022
Merged

add two tls options #207

merged 1 commit into from
Sep 19, 2022

Conversation

Omidznlp
Copy link
Contributor

@Omidznlp Omidznlp commented Sep 19, 2022

Hi,

I added two options ( rejectUnauthorized and requestCert) to TLSSocket. Could you merge the two TLS options into the code? @wbt
Thank you so much.

@wbt wbt merged commit 19eedf7 into winstonjs:master Sep 19, 2022
@wbt
Copy link
Contributor

wbt commented Sep 19, 2022

I don't have npm release permissions on this package to cut a release.

@Omidznlp
Copy link
Contributor Author

Hi, @DABH , Is it possible to release a new package?

I don't have npm release permissions on this package to cut a release.

Thank you so much for merging these features into the code. 

@DABH
Copy link
Contributor

DABH commented Sep 20, 2022

@Omidznlp I would like to cut a release, but it looks like there are some issues with unix-dgram. I opened a PR to fix these issues: bnoordhuis/node-unix-dgram#59 . If we can get that PR merged, then I should be able to do a release of winston-syslog. Fingers crossed :)

@wbt
Copy link
Contributor

wbt commented Oct 18, 2022

Looks like that PR got merged and published!

@Omidznlp
Copy link
Contributor Author

@wbt : thank you so much for your update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants