fix(lib): File Transports Not Emitting Errors On Stream Errors #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit file & daily-rotate-file add an 'error' event listener on their stream so that we can emit those errors from the transport. fixes winstonjs#511
|
@ambbell we should attempt to reopen the file stream before emitting the error. Also, this is a breaking change so it will go into the next major. |
added 2 commits
March 18, 2015 15:17
This commit only deals with streams created by the transport. Changes: - Adds public property `maxRetries` -> defaults 2 - Adds internal property `failures` -> # of failed stream creation attempts - Transport will attempt to re-create the stream on errors - Will attempt to re-create while `failures < maxRetries`
This commit adds a conditional check to file / daily-rotate-file tranports logging function. We check to make that the transport isn't currently in a failed state (i.e failures >= maxRetries) if it is in a failed state then we perform a NOOP and return an error to the logging callback.
|
@indexzero great idea - how does this look? If it looks good I'll add a couple of unit tests and push those as well. |
|
Overall lgtm now! We are getting pretty close to starting work on |
added 2 commits
March 19, 2015 12:07
changes: - 2 tests added under file-test & daily-rotate-file-test - 1 helper function added that is named `assertFailedTransport`
|
Thanks! Cherry-picked and will go out in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit file & daily-rotate-file add an 'error' event listener on
their stream so that we can emit those errors from the transport.
fixes #511