Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout after 1 min for transfer of files #518

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Timeout after 1 min for transfer of files #518

merged 1 commit into from
Jul 19, 2023

Conversation

robertdstein
Copy link
Member

Adds a timeout to the monitor for file transfer. Right now, if the file is corrupted/incomplete, then the monitor would just wait forever. That's not good. This PR adds a 1 min timeout.

@robertdstein robertdstein enabled auto-merge (squash) July 19, 2023 18:35
@coveralls
Copy link

coveralls commented Jul 19, 2023

Pull Request Test Coverage Report for Build 5602840610

  • 4 of 10 (40.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 81.455%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mirar/monitor/base_monitor.py 4 10 40.0%
Totals Coverage Status
Change from base Build 5602763334: -0.04%
Covered Lines: 8486
Relevant Lines: 10418

💛 - Coveralls

@robertdstein robertdstein merged commit b22d4f5 into main Jul 19, 2023
14 of 16 checks passed
@robertdstein robertdstein deleted the realtime branch July 19, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants