Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ultra deterministic WINTER stackID #608

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Ultra deterministic WINTER stackID #608

merged 3 commits into from
Aug 10, 2023

Conversation

virajkaram
Copy link
Collaborator

Addresses #601

@coveralls
Copy link

coveralls commented Aug 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5819968294

  • 49 of 50 (98.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 88.187%
Changes Missing Coverage Covered Lines Changed/Added Lines %
mirar/pipelines/winter/load_winter_image.py 20 21 95.24%
Totals Coverage Status
Change from base Build 5817376337: 0.009%
Covered Lines: 9518
Relevant Lines: 10793
💛 - Coveralls

robertdstein
robertdstein approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@robertdstein robertdstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robertdstein robertdstein enabled auto-merge (squash) August 10, 2023 17:10
@robertdstein
Copy link
Member

Fix #601

@robertdstein robertdstein linked an issue Aug 10, 2023 that may be closed by this pull request
[BUG] Deterministic WINTER stackid from raw images #601
Closed
@robertdstein robertdstein merged commit cc4911d into main Aug 10, 2023
14 of 16 checks passed
@robertdstein robertdstein deleted the stackid branch August 10, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertdstein robertdstein robertdstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Deterministic WINTER stackid from raw images
3 participants
@virajkaram @coveralls @robertdstein