Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logs for ExpiringActivity - WPB-9221 #1635

Merged
merged 13 commits into from
Jul 2, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 1, 2024

BugWPB-9221 Missing messages during sync

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
wire-ios-request-strategy/Sources/Synchronization/Decoding/EventDecoder.swift
wire-ios-system/Source/ExpiringActivity.swift

Issue

  1. Fix typo with DeveloperFlag.
  2. Add more logs to .
  3. TODO: add logs for

Checklist

  • Title contains a reference JIRA issue number like .
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

caldrian and others added 6 commits July 2, 2024 09:59
Co-authored-by: François Benaiteau <francois.benaiteau@wire.com>
Co-authored-by: François Benaiteau <netbe@users.noreply.github.com>
# Conflicts:
#	wire-ios-request-strategy/Sources/Notifications/PushNotificationStatus.swift
#	wire-ios-request-strategy/Sources/Synchronization/Decoding/EventDecoderTest.swift
#	wire-ios-system/WireSystem.xcodeproj/project.pbxproj
@caldrian caldrian changed the base branch from develop to fix/decrypt-and-store-events-WPB-9221-cherry-pick July 2, 2024 08:25
@caldrian caldrian force-pushed the chore/add-logs-expiring-activity-cherry-pick branch from cb07a30 to d151559 Compare July 2, 2024 08:25
@caldrian caldrian changed the title chore: add logs for ExpiringActivity WPB-9221 chore: add logs for ExpiringActivity - WPB-9221 Jul 2, 2024
Co-authored-by: Christoph Aldrian <christoph.aldrian@wire.com>
Co-authored-by: Jacob Persson <7156+typfel@users.noreply.github.com>
Copy link
Contributor Author

github-actions bot commented Jul 2, 2024

Test Results

1 244 tests   1 244 ✅  1m 48s ⏱️
  133 suites      0 💤
    2 files        0 ❌

Results for commit e7ed2f0.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jul 2, 2024

Datadog Report

Branch report: chore/add-logs-expiring-activity-cherry-pick
Commit report: 828d8c4
Test service: wire-ios-mono

✅ 0 Failed, 1244 Passed, 0 Skipped, 1.95s Total Time

…bcde138f3182592d22f' of github.com:wireapp/wire-ios into chore/add-logs-expiring-activity-cherry-pick

# Conflicts:
#	wire-ios-request-strategy/Sources/Synchronization/Decoding/EventDecoder.swift
#	wire-ios-system/Source/ExpiringActivity.swift
@KaterinaWire KaterinaWire changed the base branch from fix/decrypt-and-store-events-WPB-9221-cherry-pick to develop July 2, 2024 09:52
@KaterinaWire KaterinaWire changed the base branch from develop to fix/decrypt-and-store-events-WPB-9221-cherry-pick July 2, 2024 09:57
caldrian added 2 commits July 2, 2024 12:03
…ithub.com:wireapp/wire-ios into chore/add-logs-expiring-activity-cherry-pick
Base automatically changed from fix/decrypt-and-store-events-WPB-9221-cherry-pick to develop July 2, 2024 11:21
@caldrian caldrian enabled auto-merge July 2, 2024 11:23
@wireapp wireapp deleted a comment from github-actions bot Jul 2, 2024
@wireapp wireapp deleted a comment from github-actions bot Jul 2, 2024
@wireapp wireapp deleted a comment from github-actions bot Jul 2, 2024
@caldrian caldrian added this pull request to the merge queue Jul 2, 2024
Merged via the queue into develop with commit 550b0ae Jul 2, 2024
12 checks passed
@caldrian caldrian deleted the chore/add-logs-expiring-activity-cherry-pick branch July 2, 2024 12:46
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants