chore: Remove some dead code - WPB-10484 #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David-Henner <david.henner@wire.com>
Co-authored-by: David-Henner <david.henner@wire.com>
Co-authored-by: David-Henner <david.henner@wire.com>
Co-authored-by: David-Henner <david.henner@wire.com>
Co-authored-by: David-Henner <david.henner@wire.com>
…SSOLogin` Also remove some related code Co-authored-by: David-Henner <david.henner@wire.com>
Co-authored-by: David-Henner <david.henner@wire.com>
samwyndham
requested review from
typfel,
netbe,
David-Henner,
agisilaos and
KaterinaWire
and removed request for
typfel
samwyndham
commented
Aug 7, 2024
...re-iOS Tests/ConversationList/ConversationListViewModel/ConversationListViewModelTests.swift
Show resolved
Hide resolved
samwyndham
requested review from
johnxnguyen
and removed request for
David-Henner
Test Results 11 files 1 003 suites 22m 13s ⏱️ Results for commit 8ac30d4. ♻️ This comment has been updated with latest results. |
samwyndham
commented
Aug 7, 2024
wire-ios/Wire-iOS/Sources/Authentication/Coordinator/AuthenticationCoordinator.swift
Outdated
Show resolved
Hide resolved
johnxnguyen
approved these changes
Aug 8, 2024
…idChooseSSOLogin`" This reverts commit 81374c2.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR removes some of the dead code identified by https://github.com/peripheryapp/periphery from the
Wire-iOStarget during platform day.I've tried to remove only code that has not been introduced recently in case it has planned utility.
Testing
There should be no behavior change or automated test breakage.
Checklist
[WPB-XXX].Co-authored-by: David-Henner david.henner@wire.com