fix: Replace old verifyInAllDeviceSizes & verifyInAllIPhoneSizes with the new ones from the SnapshotHelper - WPB-10488
#1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make sure we set the snapshotHelper to nil when we tearDown.
We were using the same phone config on two places and with those changes we try to simplify the setup.
Removing <<<<<<< HEAD
agisilaos
changed the title
verifyInAllDeviceSizes & verifyInAllIPhoneSizes with the new ones from the SnapshotHelper - WPB-10488verifyInAllDeviceSizes & verifyInAllIPhoneSizes with the new ones from the SnapshotHelper - WPB-10488
Test Results 2 files 303 suites 2m 23s ⏱️ Results for commit 8d6c7de. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 1858 Passed, 0 Skipped, 7.05s Total Time |
samwyndham
approved these changes
Aug 7, 2024
That's the goal! 🎉 |
David-Henner
approved these changes
Aug 7, 2024
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I replace the old
verifyInAllDeviceSizes&verifyInAllIPhoneSizeswith the new ones coming from theSnapshotHelper. The goal is to centralize every method related to snapshot testing to theSnapshotHelper. In addition to that I cleaned things up a bit by removing to methods from theXCTestCase+SnapshotTesting.swiftand organize test classes a bit.func verifyInAllPhoneWidths( matching value: UIViewController..func verify<Value, Format>(matching value: Value...