refactor: improve architecture - WPB-11396 #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnxnguyen
commented
Oct 2, 2024
wire-ios-sync-engine/Source/Use cases/EnableAnalyticsUseCase.swift
Outdated
Show resolved
Hide resolved
johnxnguyen
commented
Oct 2, 2024
wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession+AnalyticsUser.swift
Outdated
Show resolved
Hide resolved
Test Results 4 files 712 suites 13m 18s ⏱️ Results for commit 783e4f8. ♻️ This comment has been updated with latest results. |
netbe
reviewed
Oct 2, 2024
WireAnalytics/Sources/WireAnalytics/Service/AnalyticsService.swift
Outdated
Show resolved
Hide resolved
WireAnalytics/Sources/WireAnalytics/Service/AnalyticsService.swift
Outdated
Show resolved
Hide resolved
WireAnalytics/Sources/WireAnalytics/Service/AnalyticsService.swift
Outdated
Show resolved
Hide resolved
WireAnalytics/Sources/WireAnalytics/Service/AnalyticsService.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Source/SessionManager/SessionManager+AnalyticsUseCases.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession+AnalyticsUser.swift
Outdated
Show resolved
Hide resolved
…chitecture # Conflicts: # wire-ios-sync-engine/WireSyncEngine.xcodeproj/project.pbxproj
netbe
reviewed
Oct 4, 2024
WireAnalytics/Sources/WireAnalytics/Service/AnalyticsService.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Source/SessionManager/SessionManager.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Source/UserSession/AnalyticsServiceConfiguration.swift
Show resolved
Hide resolved
wire-ios-sync-engine/Tests/Source/SessionManager/SessionManagerTests+MultiUserSession.swift
Show resolved
Hide resolved
agisilaos
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR improves the architecture or our analytics setup so that we will be able to enable analytics during the login flow and track backup restore events. It also contains some various bug fixes and small refactoring.
Changes:
AnalyticsManager,AnalyticsSessionare replaced withAnalyticsService.AnalyticsServiceencapsulates the configuration, enabling, disabling, user management and tracking of events.CountlyProtocolabstractsCountly.AnalyticsEventhas become a struct, predefined events are now created by static helpers.Testing
AnalyticsServiceChecklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: