-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Certificate pinning and proxy mode in WireAPI
- WPB-10450
#2237
Conversation
Test Results 16 files 17 suites 13m 59s ⏱️ For more details on these failures, see this check. Results for commit 07d84e0. ♻️ This comment has been updated with latest results. |
WireAPI/Sources/WireAPI/Network/NetworkService/NetworkService.swift
Outdated
Show resolved
Hide resolved
WireAPI/Sources/WireAPI/Models/Backend/ServerTrustValidator.swift
Outdated
Show resolved
Hide resolved
WireAPI
- WPB-10450WireAPI
- WPB-10450
WireAPI
- WPB-10450WireAPI
- WPB-10450
WireAPI/Sources/WireAPI/Models/Backend/ServerTrustValidator.swift
Outdated
Show resolved
Hide resolved
WireAPI/Sources/WireAPI/Models/Backend/ServerTrustValidator.swift
Outdated
Show resolved
Hide resolved
WireAPI/Sources/WireAPI/Models/Backend/ServerTrustValidator.swift
Outdated
Show resolved
Hide resolved
WireAPI/Sources/WireAPI/Models/Backend/ServerTrustValidator.swift
Outdated
Show resolved
Hide resolved
WireAPI/Sources/WireAPI/Network/NetworkService/NetworkService.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
This also fixes a compile error after merging in develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work
WireAPI/Tests/WireAPITests/Backend/ServerTrustValidatorTests.swift
Outdated
Show resolved
Hide resolved
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 8316 Passed, 31 Skipped, 5m 51.05s Total Time ❌ Failed Tests (1)
New Flaky Tests (1)
|
🤦 I accidentally merged |
WireAPI
- WPB-10450WireAPI
- WPB-10450
Issue
This PR adds a certificate pinning implementation to the
WireAPI
module. It is part of quick sync refactor. It doesn't attempt to use this new implementation in the app.The code is essentially duplicated from
WireTransport
with some modifications. Main things to look at are:ServerTrustValidator
basically combines the existingServerCertificateTrust.swift
with security key generation code fromTrustData.swift
. See my comments for specific changes.PinnedKey.swift
will replaceTrustData.swift
. It is just a basic struct without code for reading the data from file, and generating security keys.Testing
Run the automated tests.
Checklist
[WPB-XXX]
.