Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace http client with api service - WPB-14606 #2249

Merged
merged 13 commits into from
Dec 17, 2024
Merged

refactor: replace http client with api service - WPB-14606 #2249

merged 13 commits into from
Dec 17, 2024
+1,282 −1,469

Conversation

jullianm
Copy link
Contributor

@jullianm jullianm commented Dec 4, 2024 •
edited
Loading

WPB-14606

Key points

This PR replaces usage of httpClient by APIService in our multiple API components (builders and versioned APIs) from WireAPI package.

  • ConnectionsAPI
  • UsersAPI
  • FeatureConfigAPI
  • UserPropertyAPI
  • ...

Testing

  • Use APIServiceSnapshoptHelper instead of APIServiceHelper in all the API tests
  • Fix all tests accordingly
  • Ensure we also verify the generated request when asserting the response model.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@jullianm jullianm requested a review from samwyndham December 4, 2024 17:07
@echoes-hq echoes-hq bot added echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes/initiative: ios-sync-refactoring labels Dec 4, 2024
samwyndham
samwyndham approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

WireAPI/Sources/WireAPI/APIs/FeatureConfigsAPI/FeatureConfigsAPIV1.swift Outdated Show resolved Hide resolved
.../ConnectionsAPI/__Snapshots__/ConnectionsAPITests/testGetConnectionsRequest.request-0-v0.txt Show resolved Hide resolved
WireAPI/Tests/WireAPITests/APIs/FeatureConfigsAPI/FeatureConfigsAPITests.swift Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

Test Results

    8 files      9 suites   12m 24s ⏱️
7 134 tests 7 106 ✅ 28 💤 0 ❌
7 144 runs  7 116 ✅ 28 💤 0 ❌

Results for commit 22837c9.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 16, 2024 •
edited
Loading

Datadog Report

Branch report: refactor/replace-http-client-with-api-service
Commit report: 76c4144
Test service: wire-ios-mono

✅ 0 Failed, 6834 Passed, 28 Skipped, 5m 20.74s Total Time

@jullianm jullianm requested a review from johnxnguyen December 16, 2024 16:38
@jullianm jullianm enabled auto-merge December 17, 2024 08:30
@jullianm jullianm added this pull request to the merge queue Dec 17, 2024
Merged via the queue into develop with commit 7cb481c Dec 17, 2024
20 checks passed
@jullianm jullianm deleted the refactor/replace-http-client-with-api-service branch December 17, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwyndham samwyndham samwyndham approved these changes

@johnxnguyen johnxnguyen johnxnguyen approved these changes

@caldrian caldrian Awaiting requested review from caldrian

Assignees

@jullianm jullianm

Labels
echoes/initiative: ios-sync-refactoring echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jullianm @samwyndham @johnxnguyen