Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: send analytics events from individual to team migration - WPB-11319 #2277

Open
wants to merge 160 commits into
base: release/cycle-3.115
Choose a base branch
from
Open

chore: send analytics events from individual to team migration - WPB-11319 #2277

wants to merge 160 commits into from
+646 −420

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Dec 11, 2024 •
edited by github-actions bot
Loading

StoryWPB-11319 [iOS] Report Metric of Personal User creating a team in Countly

Issue

This PR adds analytics events tracking to the individual to team migration flow.

Testing

Describe how to test.

Optional: attachments like images, videos, etc.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

caldrian and others added 30 commits December 5, 2024 14:28
@caldrian
rename file
fa9c3e3
@caldrian
prepare for creating the event definitions
a41a7d5
@caldrian
declare events
4515624
@caldrian
minor adjustment
be2cbed
@caldrian
update to develop
b51e1c8
@caldrian
re-apply changes
56b2057
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into chore/pers…
bb09b2e 
…onal-to-team-analytics-WPB-11319
@caldrian
cleanup
ecb2182
@caldrian
delete Countly references
db6b5b5
@caldrian
chore: resolve todos in WireAnalytics - WPB-11881
f09c4af
@caldrian
Merge branch 'chore/resolve-todos-WPB-10941.squashed' into chore/coun…
dc03f4c 
…tly-abstraction-WPB-11319
@caldrian
fix build errors
e51a66a
@caldrian
create CountlyWrapper
eb66034
@caldrian
closure for countly
e1650d8
@caldrian
Merge remote-tracking branch 'github/gh-readonly-queue/develop/pr-225…
0aa4771 
…3-83f73ec299d6188f2bdbe2379556a7d83412179d' into chore/resolve-todos-WPB-10941.squashed
@caldrian
Merge branch 'chore/resolve-todos-WPB-10941.squashed' into chore/coun…
3774ecd 
…tly-abstraction-WPB-11319
@caldrian
linke WireAnalytics into WireDomain
6e7d6ac
@caldrian
link WireAnalytics into Wire-iOS
d7337fe
@El-Fitz
feat: show individual to team migration banner when API v7 is availab…
8da07d5 
…le & user is not part of a team
@El-Fitz
fix: dismiss banner on team creation
7c762ce
@El-Fitz
fix: dismiss banner on team creation
8a7a1aa
@caldrian
Merge branch 'feat/individual-to-team-migration-integration' into cho…
6c31c98 
…re/personal-to-team-analytics-WPB-11319
@caldrian
Merge branch 'develop' into chore/countly-abstraction-WPB-11319
72775a3
@El-Fitz
style: fix formatting
6183888
@caldrian
Merge branch 'chore/countly-abstraction-WPB-11319' into chore/persona…
6663d04 
…l-to-team-analytics-WPB-11319

# Conflicts:
#	WireDomain/Project/WireDomain Project.xcodeproj/project.pbxproj
#	wire-ios/Wire-iOS.xcodeproj/project.pbxproj
@caldrian
fix warning
783709d
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into chore/coun…
5d53a9d 
…tly-abstraction-WPB-11319
@El-Fitz
fix: check API version, refactor calls
788fd88
@El-Fitz
style: fix formatting
7dcf480
@El-Fitz
style: fix formatting
63de94f
Base automatically changed from fix/misc-individual-to-team-fixes to develop December 13, 2024 20:55
@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Dec 13, 2024
@caldrian caldrian changed the base branch from develop to release/cycle-3.115 December 16, 2024 11:18
@caldrian caldrian requested a review from samwyndham December 16, 2024 11:19
@caldrian caldrian requested a review from johnxnguyen December 16, 2024 11:40
caldrian
caldrian commented Dec 16, 2024
View reviewed changes
WireAnalytics/Sources/WireAnalytics/Events/Predefined/AnalyticsEvent.Calling.swift Outdated Show resolved Hide resolved
WireAnalytics/Sources/WireAnalytics/Events/Predefined/AnalyticsEvent.Contributed.swift Outdated Show resolved Hide resolved
WireAnalytics/Sources/WireAnalytics/Events/Predefined/AnalyticsEvent.Backup.swift Outdated Show resolved Hide resolved
WireAnalytics/Sources/WireAnalytics/Events/Predefined/AnalyticsEvent.App.swift Outdated Show resolved Hide resolved
WireAnalytics/Sources/WireAnalytics/Events/Predefined/AnalyticsEvent.UI.swift Outdated Show resolved Hide resolved
WireAnalytics/Sources/WireAnalytics/Events/Predefined/AnalyticsEvent.User.swift Outdated Show resolved Hide resolved
WireAnalytics/Sources/WireAnalytics/Events/Segmentation/AnalyticsValue.swift Show resolved Hide resolved
@caldrian caldrian enabled auto-merge (squash) December 16, 2024 13:38
samwyndham
samwyndham approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

.github/workflows/swiftformat.yml Show resolved Hide resolved
WireAnalytics/Sources/WireAnalytics/Events/Predefined/AnalyticsEvent.Backup.swift Outdated Show resolved Hide resolved
WireAnalytics/Sources/WireAnalytics/Events/Predefined/AnalyticsEvent.UI.swift Outdated Show resolved Hide resolved
WireAnalytics/Sources/WireAnalytics/Events/Predefined/AnalyticsEvent.UI.swift Outdated Show resolved Hide resolved
El-Fitz
El-Fitz approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@El-Fitz El-Fitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me.
Not a big fan of centralising all the events, but that's something for another day.

@caldrian
Merge branches 'release/cycle-3.115' and 'chore/personal-to-team-anal…
2e8c032 
…ytics-WPB-11319' of github.com:wireapp/wire-ios into chore/personal-to-team-analytics-WPB-11319
@caldrian
address PR comments
f1cd332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwyndham samwyndham samwyndham approved these changes

@johnxnguyen johnxnguyen johnxnguyen approved these changes

@El-Fitz El-Fitz El-Fitz approved these changes

Assignees

@caldrian caldrian

Labels
echoes/initiative: personal-users-to-team-users... echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes: unplanned Any work item that isn’t part of the product or technical roadmap. release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@caldrian @samwyndham @El-Fitz @johnxnguyen @netbe