fix: pass CI env explicitly in fastfile and testplans - WPB-14950 #2278
+300
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: technical-roadmap/throughput
Test Results 20 files 29 suites 13m 56s ⏱️ Results for commit 3962f17. ♻️ This comment has been updated with latest results. |
netbe
force-pushed
the
fix/ci-snapshots-WPB-14950
branch
from
14ace59 to
1511df8
Compare
…ios into fix/ci-snapshots-WPB-14950
johnxnguyen
approved these changes
Dec 13, 2024
jullianm
approved these changes
Dec 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Previous PR #2256 didn't fix the snapshots failure being ignored on CI. Here we explicitly set the CI environement in test plans and fastlane.
CI environment variable needs to be declared like: CI=${CI} with targetForVariableExpansion.
Note: for packages with multiple target I took one by default like WireDesign for WireUI (I haven't found another way to pass it correctly).
Testing