-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove karma + jasmine and replace with jest globally #4546
Conversation
e4a84b9
to
e0ebcc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could try to hoist the import of jest and swc to the root package.json and remove them from every single package, WDYT?
I tried this. I could only run tests from root in this case and trying to run them from packages error Ed because the dependencies haven't been found. I think this is the case because the yarn.yaml hoists to packages per setting. |
I think it's because it's a binary that is executed and in this case it should be defined at the package level. |
I actually found a solution. Enjoy :) |
…nage their own node modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid 💪
The goal of this PR is to streamline our Testrunner for every package in the Monorepo.
Until now we used a couple of solutions like:
The goal of this PR is:
What has been done to archive the Goal:
Open problems
1. Running jest from root
When running jest from root by executing "yarn jest", some package tests will fail because dependencies like TextEncoder can't be found or some global variables are not defined. I don't have a fix for that (yet), but its also not on the priority list since we execute scripts directly from the package folder (that don't have this problem).
As soon as we have a fix for this behaviour we can just execute jest from root to collect combined coverage of all packages. Also enables tools like Wallaby to be fully usable from root without having some tests error.
2. Running build before test execution
Some test (not many) need the built binaries from other packages to be able to execute their tests. Currently we build every package before running the tests, which costs a lot of time. We have a high potential to speed up the process if we cut down the build step before test execution.