Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Prettier #1729

Merged
merged 45 commits into from
Oct 25, 2017
Merged

style: Prettier #1729

merged 45 commits into from
Oct 25, 2017

Conversation

lipis
Copy link
Contributor

@lipis lipis commented Sep 21, 2017

Prettier

Read more about it here: https://github.com/prettier/prettier

Key changes


New/modified commands:

  • yarn fix
    Fixes all the possible file extensions that we support (js, json, less)

  • yarn fix:script
    Fixes all the script files (js)

  • yarn fix:config
    Fixes all the config files (json)

  • yarn fix:style
    Fixes all the styke files (less)

  • yarn test
    Executes all the tests

  • yarn test:script
    Tests if the scripts are fine, but not modifying them

@ffflorian
Copy link
Contributor

Someone wants to become contributor nr. 1? 😛

@lipis
Copy link
Contributor Author

lipis commented Sep 21, 2017

To become #1 I need to push 800 different commits.. 🗡 :D

@lipis
Copy link
Contributor Author

lipis commented Sep 21, 2017

and I'm still going to be second :P

@lipis
Copy link
Contributor Author

lipis commented Oct 6, 2017

Vote here

@lipis lipis removed the request for review from bennycode October 7, 2017 13:39
@gregor
Copy link
Contributor

gregor commented Oct 12, 2017

But it won't be flagged any longer. If you add a max line lenght in eslint you can set it to warn you or fail your build. A set line lenght in prettier will simply, silently reformat the code.

@lipis
Copy link
Contributor Author

lipis commented Oct 12, 2017

We are talking for something that we have it disable actually: https://eslint.org/docs/rules/max-len

@gregor
Copy link
Contributor

gregor commented Oct 12, 2017

Yes, it is disabled since it was also creating too much noise in the past. We are not discussing the current state but how we can move forward with the tools to server our needs.

Copy link
Contributor

@bennycode bennycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do yarn fix:config (instead of fix:json) to be consistent with fix:script and fix:style.

@lipis
Copy link
Contributor Author

lipis commented Oct 20, 2017

@bennyn updated

@lipis lipis merged commit a0dcb1f into dev Oct 25, 2017
@lipis lipis deleted the prettier branch October 25, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants