Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Update Sample App #102

Merged
merged 8 commits into from
Nov 29, 2020
Merged

WIP Update Sample App #102

merged 8 commits into from
Nov 29, 2020

Conversation

flschweiger
Copy link
Member

Currently a WIP, come back soon 🚧

Copy link
Member Author

@flschweiger flschweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have changed a few things in the actual sample app but otherwise great job 👍 Just let me know if we should keep the new package name or if you want to adjust it back to example @atoka93

@@ -38,9 +38,9 @@ android {

defaultConfig {
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
applicationId "io.wiredash.example"
applicationId "io.wiredash.flutter_app"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why changing the applicationId to .flutter_app?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintended, will revert it.

@passsy
Copy link
Member

passsy commented Nov 29, 2020

How to recreate/update the example app:

flutter channel beta
flutter upgrade
flutter config --enable-web    
flutter config --enable-macos-desktop
rm -rf example
flutter create --org io.wiredash --project-name example example

return ListTile(
title: Text('Sample Item #$index'),
subtitle: const Text('Tap me to open a new page'),
onTap: () => _openDetailsPage(context, index),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally forgot about that. 💪

revision: 659dc8129d4edb9166e9a0d600439d135740933f
channel: beta
revision: 022b333a089afb81c471ec43d1f1f4f26305d876
channel: dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the upgrade to dev intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was for creating the MacOS project files but we can also revert to beta.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This did now work for me. I wasn't able to compile the app at all on iOS. I reverted back to stable (to recreate the project). It now works with Flutter stable/beta/dev

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this affect MacOS?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm (on dev 1.24.0-10.2.pre)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants