Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show only one Wiredash feedback flow at a time #81

Merged
merged 3 commits into from
Sep 20, 2020
Merged

Show only one Wiredash feedback flow at a time #81

merged 3 commits into from
Sep 20, 2020

Conversation

roughike
Copy link
Contributor

@roughike roughike commented Sep 19, 2020 •
edited
Loading

Fixes the use case in #62, specifically #62 (comment).

When calling Wiredash.of(context).show(), a new FeedbackSheet will be only pushed if there's no existing one open.

@roughike roughike mentioned this pull request Sep 19, 2020
Closed
flschweiger
flschweiger approved these changes Sep 19, 2020
View reviewed changes
Copy link
Member

@flschweiger flschweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@roughike roughike merged commit 51a3df6 into wiredashio:master Sep 20, 2020
@roughike roughike deleted the fix/only-one-feedback-flow-at-a-time branch September 20, 2020 09:49
@RibuRoyson RibuRoyson mentioned this pull request Mar 8, 2024
Closed
@ribuemsyne ribuemsyne mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flschweiger flschweiger flschweiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roughike @flschweiger