Improve Accessibility #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brianegan-wiredash
commented
Oct 20, 2020
•
brianegan-wiredash
commented
- Run Accessibility Scanner on Android and address all flagged issues
- Run Accessibility Inspector on iOS and verify ability to navigate Wiredash SDK
- Fix the order of items in Stack to make buttons accessible by screen readers
- Increase Button Sizes
- Add labels to all buttons
- Add labels to all images
|
I've just updated Polish translation of the a11y texts |
|
Thanks so much @orestesgaolin |
- Create internal providers - Use AnimatedBuilders to listen to changes
- Run Accessibility Scanner on Android - Run Accessibility Inspector on iOS - Fix inaccessible buttons - Increase Button Sizes - Add labels to all buttons - Add labels to all images
brianegan-wiredash
force-pushed
the
fix-accessibility-issues
branch
from
1becab2
to
f06833d
Compare
|
Going ahead and merging this one in! I didn't get any thumbs up nor thumbs down, assuming it's ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.