Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use agate.Table.print_table() in csvlook, closes #515 #538

Merged
merged 5 commits into from
Jan 31, 2016
Merged

Conversation

jpmckinney
Copy link
Member

@onyxfish Please review the changes to the tests (having to do with type inference) to see if this is the desired new behavior. If so, we'll need to document the changes in the changelog.

@jpmckinney
Copy link
Member Author

One issue remaining:

  1. --linenumbers is broken, as agate's print_table doesn't understand this. Only its csv.writer takes a line_numbers argument. One solution is to add line_numbers to agate's csv.reader, which would mirror the old csvlook implementation.

@jpmckinney
Copy link
Member Author

Removing the failing test for now so that I'm not blocked.

jpmckinney pushed a commit that referenced this pull request Jan 31, 2016
Use agate.Table.print_table() in csvlook, closes #515
@jpmckinney jpmckinney merged commit 9486792 into master Jan 31, 2016
@jpmckinney jpmckinney deleted the csvlook branch January 31, 2016 18:32
lcorbasson pushed a commit to lcorbasson/csvkit that referenced this pull request Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant