Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] color mark at connector pins #53

Closed
quotschmacher opened this issue Jul 1, 2020 · 3 comments
Closed

[feature] color mark at connector pins #53

quotschmacher opened this issue Jul 1, 2020 · 3 comments
Milestone

Comments

@quotschmacher
Copy link

add the ability to add a small color mark or something similar at connector pins.

@formatc1702
Copy link
Collaborator

formatc1702 commented Jul 2, 2020

You mean each pin might have a color assigned to it? That would mean we would need a new optional list-type parameter with the same length as pinout (and optionally pinnumbers). This sounds like a good idea.

I was also thinking of the option to specify a color for the entire connector (just in case)... so far this is only used for ferrules (not featured in the examples so far).

Screen Shot 2020-07-02 at 06 53 29

If anybody wants to take this on, please let me know. I don't think I will find time for this soon, myself.

Thanks for the request!

@formatc1702
Copy link
Collaborator

formatc1702 commented Jul 2, 2020

Internal note: This (both the original suggestion and the ability to assign color to entire connector) will require rewriting the node's GraphViz code from a record (which is much more compact code-wise, but does not support colors inside cells AFAIK) to a proper HTML node (just like cables are already implemented)

formatc1702 added a commit that referenced this issue Jul 2, 2020
Add hack to make manufacturer / part number row have vertical separators, to be visually consistent with connectors.

In the future, connectors will have to be modified to be HTML tables instead of GraphViz record nodes, in order to support colored bands for the connector, or individual pins (#53). When this is implemented, a cleaner solution should be found for both connectors and cables.
formatc1702 added a commit that referenced this issue Jul 2, 2020
Add hack to make manufacturer / part number row have vertical separators, to be visually consistent with connectors.

In the future, connectors will have to be modified to be HTML tables instead of GraphViz record nodes, in order to support colored bands for the connector, or individual pins (#53). When this is implemented, a cleaner solution should be found for both connectors and cables.
@formatc1702
Copy link
Collaborator

Internal note: This (both the original suggestion and the ability to assign color to entire connector) will require rewriting the node's GraphViz code from a record (which is much more compact code-wise, but does not support colors inside cells AFAIK) to a proper HTML node (just like cables are already implemented)

Update: Ferrules have been refactored in #65. Original issue still open.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants