Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bgcolor attribute to connectors and cables #219

Merged
merged 7 commits into from
Sep 28, 2021
Merged

Add bgcolor attribute to connectors and cables #219

merged 7 commits into from
Sep 28, 2021

Commits on Sep 24, 2021

  1. Add bgcolor attribute to connectors and cables 

    This solves the wireviz#210 suggestion to render the title row of
the graph nodes with this bgcolor.
    @kvid
    kvid committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    52d6d3c View commit details
    Browse the repository at this point in the history

  2. Support both bgcolor and bgcolor_title attributes 

    Solves wireviz#210 completely by supporting bgcolor of both the node title
and the whole node independently using separate attributes.
    @kvid
    kvid committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    15e5189 View commit details
    Browse the repository at this point in the history

  3. Support image.bgcolor to enable adapting to image colors

    @kvid
    kvid committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    9d64194 View commit details
    Browse the repository at this point in the history

  4. Support bgcolor of additional components 

    Maybe not needed that much, but mainly for consistency, to support
bgcolor in all dataclasses that represent boxes in the diagram.
    @kvid
    kvid committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    cf01502 View commit details
    Browse the repository at this point in the history

  5. Support specifying hex colors where no color name is needed 

    This was requested by designer2k2 in wireviz#219 for bgcolor usage.
It has also been discussed in wireviz#135.

The input validation is more detailed to help the user identifying
and locating invalid values. The wire color padding is now done on
the output to cover different input alternatives.
    @kvid
    kvid committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    23713b2 View commit details
    Browse the repository at this point in the history

  6. Support specifying hex colors for any color attributes

    @kvid
    kvid committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    e6e2055 View commit details
    Browse the repository at this point in the history

  7. Move color type aliases into wv_colors.py to avoid circular imports

    @kvid
    kvid committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    7d510b2 View commit details
    Browse the repository at this point in the history