-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better additional component BOM table #226
base: dev
Are you sure you want to change the base?
Commits on Dec 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0f3b5e9 - Browse repository at this point
Copy the full SHA 0f3b5e9View commit details -
Simplify get_bom_index() parameters
- Use the actual BOM as first parameter instead of the whole harness. - Use a whole AdditionalComponent as second parameter instead of each attribute separately.
Configuration menu - View commit details
-
Copy full SHA for 6525537 - Browse repository at this point
Copy the full SHA 6525537View commit details -
Use the same lambda in get_bom_index() as for deduplicating BOM
Move the lambda declaration out of the function scope for common access from two different functions.
Configuration menu - View commit details
-
Copy full SHA for 45b13ef - Browse repository at this point
Copy the full SHA 45b13efView commit details -
Configuration menu - View commit details
-
Copy full SHA for da453db - Browse repository at this point
Copy the full SHA da453dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 347f1e3 - Browse repository at this point
Copy the full SHA 347f1e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6378b96 - Browse repository at this point
Copy the full SHA 6378b96View commit details -
Simplify collecting designators for a joined BOM entry
Assign input designators once to a temporary variable for easy reusage.
Configuration menu - View commit details
-
Copy full SHA for d2f8034 - Browse repository at this point
Copy the full SHA d2f8034View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1d7bab - Browse repository at this point
Copy the full SHA e1d7babView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74462cd - Browse repository at this point
Copy the full SHA 74462cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10b1198 - Browse repository at this point
Copy the full SHA 10b1198View commit details -
Move BOM sorting above grouping to use groupby()
- Use one common entry loop to consume iterator only once. - Use same key function for sort() and groupby(), except replace None with empty string when sorting.
Configuration menu - View commit details
-
Copy full SHA for cdca708 - Browse repository at this point
Copy the full SHA cdca708View commit details -
Configuration menu - View commit details
-
Copy full SHA for f13f8a7 - Browse repository at this point
Copy the full SHA f13f8a7View commit details -
Use a generator expressions and raise exception if failing
Seems to be the most popular search alternative: https://stackoverflow.com/questions/8653516/python-list-of-dictionaries-search Raising StopIteration if not found is better than returning None to detect such an internal error more easily.
Configuration menu - View commit details
-
Copy full SHA for 96d393d - Browse repository at this point
Copy the full SHA 96d393dView commit details -
Replace accumulation loop with sum expressions
Make a list from the group iterator for reusage in sum expressions and to pick first group entry. The expected group sizes are very small, so performance loss by creating a temporary list should be neglectable. Alternativly, itertools.tee(group, 3) could be called to triplicate the iterator, but it was not chosen for readability reasons.
Configuration menu - View commit details
-
Copy full SHA for 1d653c4 - Browse repository at this point
Copy the full SHA 1d653c4View commit details
Commits on Jan 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 12e570f - Browse repository at this point
Copy the full SHA 12e570fView commit details -
This type alias describes the possible types of keys and values in the dict representing a BOM entry.
Configuration menu - View commit details
-
Copy full SHA for c22c42e - Browse repository at this point
Copy the full SHA c22c42eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6d0d2a - Browse repository at this point
Copy the full SHA d6d0d2aView commit details -
Build output string in one big expression
Build output string in component_table_entry() as the similar strings in generate_bom(). Repeating a couple of minor if-expressions is small cost to obtain a more compact and readable main expression.
Configuration menu - View commit details
-
Copy full SHA for d15eeb1 - Browse repository at this point
Copy the full SHA d15eeb1View commit details
Commits on Jan 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2e24498 - Browse repository at this point
Copy the full SHA 2e24498View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e7c48d - Browse repository at this point
Copy the full SHA 8e7c48dView commit details
Commits on Jan 6, 2021
-
Rename the 'item' key to 'description' in all BOMEntry dicts
This way, both BOM and harness.additional_bom_items uses the same set of keys in their dict entries. This was originally suggested in a #115 review, but had too many issues to be implemented then.
Configuration menu - View commit details
-
Copy full SHA for 30dbd95 - Browse repository at this point
Copy the full SHA 30dbd95View commit details
Commits on Feb 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 183a943 - Browse repository at this point
Copy the full SHA 183a943View commit details
Commits on Mar 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 523d0c6 - Browse repository at this point
Copy the full SHA 523d0c6View commit details
Commits on Mar 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8c26c8f - Browse repository at this point
Copy the full SHA 8c26c8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e61d14b - Browse repository at this point
Copy the full SHA e61d14bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53fefa8 - Browse repository at this point
Copy the full SHA 53fefa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dc02fe - Browse repository at this point
Copy the full SHA 0dc02feView commit details -
remove
component_table_entry()
as separate func.to simplyfy code
Configuration menu - View commit details
-
Copy full SHA for 9a93d86 - Browse repository at this point
Copy the full SHA 9a93d86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4338b7a - Browse repository at this point
Copy the full SHA 4338b7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e168ea - Browse repository at this point
Copy the full SHA 7e168eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f928bc7 - Browse repository at this point
Copy the full SHA f928bc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaf88d7 - Browse repository at this point
Copy the full SHA aaf88d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6aa53f6 - Browse repository at this point
Copy the full SHA 6aa53f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09d5496 - Browse repository at this point
Copy the full SHA 09d5496View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f86c97 - Browse repository at this point
Copy the full SHA 1f86c97View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4a0ae5 - Browse repository at this point
Copy the full SHA b4a0ae5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37bf530 - Browse repository at this point
Copy the full SHA 37bf530View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9821ca3 - Browse repository at this point
Copy the full SHA 9821ca3View commit details