Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--debug should not display postingWif from a config #28

Closed
noisy opened this issue Dec 10, 2018 · 2 comments
Closed

--debug should not display postingWif from a config #28

noisy opened this issue Dec 10, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@noisy
Copy link
Contributor

noisy commented Dec 10, 2018

The problem

Private posting key is displayed in logs when --debug is used. We should never display any private data in logs

I did

wise --debug download-rules -a lenka ./lenka.yml

I expected to see:

wise --debug download-rules -a lenka ./lenka.yml
log.level["steem-wise-cli"]="debug"
steem-wise-cli | Trying to read config from /home/noisy/.wise/config.yml
steem-wise-cli | Failed to parse config (/home/noisy/.wise/config.yml) as JSON: Unexpected token u in JSON at position 0
steem-wise-cli | Successfully parsed /home/noisy/.wise/config.yml as YAML
steem-wise-cli | Loaded config: {"username":"noisy3","postingWif":"*********************************************************","steemApi":"https://anyx.io","defaultSyncStartBlockNum":28438545,"defaultRulesPath":"rules.yml","syncedBlockNumFile":"synced-block-num.txt","disableSend":false,"configFilePath":"/home/noisy/.wise/config.yml"}
Downloading rules set by @lenka...
Rules saved to file /home/noisy/.wise/lenka.yml

Instead, I saw:

image


Version of steem-wise-core: 3.0.6-rc1
Version of nodejs: 10.0.5

@noisy noisy added the bug Something isn't working label Dec 10, 2018
@Jblew
Copy link
Member

Jblew commented Dec 11, 2018

Done

@Jblew Jblew closed this as completed Dec 11, 2018
@noisy
Copy link
Contributor Author

noisy commented Dec 13, 2018

tested, it looks ok 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants