Added ExpandableResultsEntry #6
Conversation
|
Found a problem with. Because it rebuilds the list, and it was just activated, it moves the one you just click on to the top instead of inline. This also can cause problems where it doesn't fully scroll back to the top |
src/client/java/io/wispforest/limelight/impl/ui/ResultsContainerComponent.java
Outdated
Show resolved
Hide resolved
src/client/java/io/wispforest/limelight/impl/ui/ResultEntryComponent.java
Show resolved
Hide resolved
| if (isExpanded) { | ||
| for (ResultEntry e : ((ExpandableResultEntry)entry).getChildren()) | ||
| child(new ResultEntryComponent(screen, e, true, false)); | ||
| } |
There was a problem hiding this comment.
I assume this just doesn't do anything if a child entry of an expandable entry is also expandable?
There was a problem hiding this comment.
Yes, I probably should have documented somewhere, but this behavior is intentional. There isn't a good way to distinguish child-child entries visually (especially not one that scales to the theoretical infinite nesting), and it would greatly complicate things
src/client/java/io/wispforest/limelight/api/entry/ExpandableResultEntry.java
Outdated
Show resolved
Hide resolved
src/client/java/io/wispforest/limelight/impl/config/LimelightTheme.java
Outdated
Show resolved
Hide resolved
src/client/java/io/wispforest/limelight/impl/ui/ExpandIndicatorComponent.java
Outdated
Show resolved
Hide resolved
src/client/java/io/wispforest/limelight/impl/ui/ResultEntryComponent.java
Outdated
Show resolved
Hide resolved
| screen.searchBox.onCharTyped(chr, modifiers); | ||
|
|
||
| return true; | ||
| if (root() != null) { |
There was a problem hiding this comment.
why would root() be null here? aren't input events only routed to components if they're mounted?
There was a problem hiding this comment.
why would root() be null here?
IDK. I just now that it can, because it crashed. I'll see if this still happens after my aforementioned changes
yeah i want to make rebuilding the result list actually keep focus (mainly because I want to make it so that it's rebuilt if you run any entry that doesn't close the screen) |
|
Ah rip, I missed your review at first and completely re-did how the child entries get added due to the bug I mentioned. (I mean it doesn't fully work yet but yeah) |
…requested changes
|
Okay, I know there is one problem with the commit I just made, but I need to do something else and just wanted to push. There is nothing stopping child entries from expanding, but if they do it will break the new system, so I got to make the system work with that, or make it so they aren't able to expand in the first place |
|
Ready for review |
Adds a ExpandableResultEntry, which has a method to get child entries. When a ExpandableResultEntry is selected, it adds it's children below it (with adjusted background color) and the expandable icon is rotated. Child-entries don't sorted by usage, and this is intentional. Though the theming might need adjustment