tweak child_specs #47
Conversation
benonymus
force-pushed
the
tweak_child_specs
branch
from
08ea561
to
11c6c11
Compare
benonymus
force-pushed
the
tweak_child_specs
branch
from
11c6c11
to
d2d5e01
Compare
lib/nsq/connection.ex
Outdated
| @@ -62,18 +63,15 @@ defmodule NSQ.Connection do | |||
| # ------------------------------------------------------- # | |||
| # Behaviour Implementation # | |||
| # ------------------------------------------------------- # | |||
| @spec start_link(pid, host_with_port, NSQ.Config.t(), String.t(), String.t(), pid, list) :: | |||
| @spec start_link(pid | host_with_port | NSQ.Config.t() | String.t() | String.t() | pid) :: | |||
There was a problem hiding this comment.
This spec says you receive a single argument that is any one of these. However, you actually receive a list with each of these positionally located in that list. The correct spec would be the following:
| @spec start_link(pid | host_with_port | NSQ.Config.t() | String.t() | String.t() | pid) :: | |
| @spec start_link([pid, host_with_port, NSQ.Config.t(), String.t(), String.t(), pid]) :: |
It looks like you have the same problem in a couple other places that you should fix as well.
There was a problem hiding this comment.
Hey, good one!
I was scratching my head on this a bit.
If I do this (at a different function but same at all) I get this error when I compile:
unexpected list in typespec: [binary(), NSQ.Config.t()]
I couldn't really find any working examples of this, or could not make it work.
There was a problem hiding this comment.
I think the simplest here is to use tuples instead of the lists.
If you know how to make the list work let me know!
Cheers
There was a problem hiding this comment.
Yea, I think tuple is probably what's appropriate here.
According to the docs this setup is less error prone, since we don't define the maps anymore.
To support the tuple child spec I changed some
start_links.I also noticed a missing
use Genserverwhich could lead to unexpected things I think.