-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudflare): add service bindings #179
feat(cloudflare): add service bindings #179
Conversation
🦋 Changeset detectedLatest commit: 8ea9c8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
the adapter already has an option called `bindings`, so using "binding" in the type name seemed obsolete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Block merge, because it needs docs pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for docs! 🙌
Changes
@astrojs/cloudflare
adapter.astro.config.ts
(pages
type) and reading them fromwrangler.toml
(workers
type) have been implemented.Testing
Changes have been tested by updating the
dev-runtime-pages
anddev-runtime-workers
fixtures and adding an integration test toz-dev-runtime-pages.test.js
anddev-runtime-workers.test.js
respectively.Docs
Since this is a feature, it does not affect current users, but the documentation will need to be updated.
closes #175