proceed as usual after warning

withastro · Dec 6, 2023 · 15420ce · 15420ce
1 parent 61b5c17
commit 15420ce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/astro/src/core/routing/manifest/create.ts b/packages/astro/src/core/routing/manifest/create.ts
@@ -460,7 +460,7 @@ export function createRouteManifest(
 				destination = to.destination
 			}
 			if (destination.startsWith("http")) {
-				return logger.error('redirects', `Redirecting to an external URL is not supported: ${from} -> ${to}`);
+				logger.warn('redirects', `Redirecting to an external URL is not officially supported: ${from} -> ${to}`);
 			}
 		}
 

diff --git a/packages/astro/test/redirects.test.js b/packages/astro/test/redirects.test.js
@@ -28,7 +28,8 @@ describe('Astro.redirect', () => {
 			expect(response.headers.get('location')).to.equal('/login');
 		});
 
-		it('Ignores external redirect', async () => {
+		// ref: https://github.com/withastro/astro/pull/9287
+		it.skip('Ignores external redirect', async () => {
 			const app = await fixture.loadTestAdapterApp();
 			const request = new Request('http://example.com/external/redirect');
 			const response = await app.render(request);